1From 9836e2211ba8b3035a1d390bbf6a0eebe4c2439d Mon Sep 17 00:00:00 2001 2From: Fabrice Fontaine <fontaine.fabrice@gmail.com> 3Date: Thu, 3 Nov 2022 17:19:09 +0100 4Subject: [PATCH] configure.ac: fix readline static build 5 6Use pkg-config to retrieve readline dependencies such as ncurses to 7avoid the following static build when readline is built with ncurses 8support (which is raised since version 1.8.19 and 9https://github.com/ipmitool/ipmitool/commit/63dd71c39c9bf522ad3a785dd001737a285458eb): 10 11** Unable to build Solaris 9 x86 IPMI interface support! 12checking for library containing readline... no 13configure: error: ** Unable to find readline required by ipmishell. 14 15[...] 16 17configure:15125: /tmp/instance-0/output-1/host/bin/armeb-buildroot-linux-musleabi-gcc -o conftest -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -O0 -g0 -static -Wall -Wextra -std=gnu11 -pedantic -Wformat -Wformat-nonliteral -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -static conftest.c -lreadline -lcrypto >&5 18/tmp/instance-0/output-1/host/lib/gcc/armeb-buildroot-linux-musleabi/11.3.0/../../../../armeb-buildroot-linux-musleabi/bin/ld: /tmp/instance-0/output-1/host/armeb-buildroot-linux-musleabi/sysroot/usr/lib/libreadline.a(display.o): in function `_rl_move_cursor_relative': 19display.c:(.text+0x80fc): undefined reference to `tputs' 20 21Fixes: 22 - http://autobuild.buildroot.org/results/dabc6a4f49d464c129ac6bc3710011678142fcbe 23 24Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> 25[Upstream status: https://github.com/ipmitool/ipmitool/pull/374] 26--- 27 configure.ac | 6 +++++- 28 1 file changed, 5 insertions(+), 1 deletion(-) 29 30diff --git a/configure.ac b/configure.ac 31index d6ba62b..4ee1be8 100644 32--- a/configure.ac 33+++ b/configure.ac 34@@ -624,7 +624,11 @@ AC_ARG_ENABLE([ipmishell], 35 36 dnl check for readline library to enable ipmi shell 37 if test "x$xenable_ipmishell" = "xyes"; then 38- AC_SEARCH_LIBS([readline], [readline edit], [have_readline=yes]) 39+ PKG_PROG_PKG_CONFIG 40+ PKG_CHECK_MODULES([READLINE], [readline], 41+ [LIBS="$LIBS $READLINE_LIBS" have_readline=yes], 42+ [AC_SEARCH_LIBS([readline], [readline edit], [have_readline=yes])] 43+ ) 44 if test "x$have_readline" != "xyes"; then 45 AC_MSG_ERROR([** Unable to find readline required by ipmishell.]) 46 xenable_ipmishell=no 47-- 482.35.1 49 50