1From 8df3a56cfb104c84d4701562ae2e3c9dc4686798 Mon Sep 17 00:00:00 2001
2From: Fabrice Fontaine <fontaine.fabrice@gmail.com>
3Date: Sat, 6 Feb 2021 11:08:45 +0100
4Subject: [PATCH] configure.ac: fix static linking with id3tag
5
6Put back -lz (i.e. ZLIB_LIBS) when searching for id3tag which was
7wrongly removed by commit 6ff0e9322f9891f5a6ac6c9b3bceffbfca16bec3. This
8will fix the following static build failure:
9
10configure:15290: checking for id3_file_open in -lid3tag
11configure:15315: /home/buildroot/autobuild/instance-0/output-1/host/bin/arm-linux-gcc -o conftest -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64  -O2   -static -Wall -Wmissing-prototypes -Wstrict-prototypes  -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64  -static -Wl,--as-needed conftest.c -lid3tag    >&5
12conftest.c:60:1: warning: function declaration isn't a prototype [-Wstrict-prototypes]
13   60 | char id3_file_open ();
14      | ^~~~
15conftest.c:62:1: warning: function declaration isn't a prototype [-Wstrict-prototypes]
16   62 | main ()
17      | ^~~~
18/home/buildroot/autobuild/instance-0/output-1/host/opt/ext-toolchain/bin/../lib/gcc/arm-buildroot-linux-uclibcgnueabi/9.3.0/../../../../arm-buildroot-linux-uclibcgnueabi/bin/ld: /home/buildroot/autobuild/instance-0/output-1/host/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib/libid3tag.a(util.o): in function `id3_util_compress':
19util.c:(.text+0x1ac): undefined reference to `compress2'
20/home/buildroot/autobuild/instance-0/output-1/host/opt/ext-toolchain/bin/../lib/gcc/arm-buildroot-linux-uclibcgnueabi/9.3.0/../../../../arm-buildroot-linux-uclibcgnueabi/bin/ld: /home/buildroot/autobuild/instance-0/output-1/host/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib/libid3tag.a(util.o): in function `id3_util_decompress':
21util.c:(.text+0x240): undefined reference to `uncompress'
22
23Fixes:
24 - http://autobuild.buildroot.org/results/73efdacf237e3d567fa66f3b3f68e624f5e35bc7
25
26Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
27[Upstream status: https://sourceforge.net/p/sox/patches/123]
28---
29 configure.ac | 2 +-
30 1 file changed, 1 insertion(+), 1 deletion(-)
31
32diff --git a/configure.ac b/configure.ac
33index 39306398..896714f5 100644
34--- a/configure.ac
35+++ b/configure.ac
36@@ -83,7 +83,7 @@ dnl Various libraries
37 SOX_WITH_LIB([magic], [magic.h], [magic], [magic_open])
38 SOX_CHECK_LIB([ZLIB], [zlib.h], [z], [uncompress])
39 SOX_WITH_LIB([png], [png.h], [png], [png_set_rows], [], [], [], [$ZLIB_LIBS])
40-SOX_WITH_LIB([id3tag], [id3tag.h], [id3tag], [id3_file_open])
41+SOX_WITH_LIB([id3tag], [id3tag.h], [id3tag], [id3_file_open], [], [], [], [$ZLIB_LIBS])
42 SOX_WITH_LIB([libgsm], [gsm/gsm.h gsm.h], [gsm], [gsm_create])
43
44 dnl Optional formats
45--
462.29.2
47
48